search

flyx / NimYAML

YAML implementation for Nim
https://nimyaml.org
Other
186 stars 36 forks source link

Make it work with new not nil #62

Closed alehander92 closed 5 years ago

alehander92 commented 6 years ago

string and seq don't need, and can't have not nil anymore.

I am not sure if this doesn't break something

flyx commented 6 years ago

This fix is not correct since it now treats empty strings / seqs as if they were a nil value which they are not.

Proper fix would be to completely remove yTagNimNilString and yTagNimNilSeq and remove the corresponding if branches. Documentation also needs to be updated, but that can't be done here since it's in the gh-pages branch.

flyx commented 5 years ago

Obsolete; fixed by #64

alehander92 commented 5 years ago

great work, thanks