search

flyx / NimYAML

YAML implementation for Nim
https://nimyaml.org
Other
191 stars 36 forks source link

"test/yaml-test-suite" submodule broken by upstream #77

Closed stefantalpalaru closed 4 years ago

stefantalpalaru commented 4 years ago 
$ git submodule update --recursive --init
Submodule 'test/yaml-test-suite' (https://github.com/yaml/yaml-test-suite.git) registered for path 'test/yaml-test-suite'
Cloning into '/mnt/sda3/storage/CODE/status/NimYAML/test/yaml-test-suite'...
error: Server does not allow request for unadvertised object fa266d172ef7b2cdd35219b8e677fa5e0ae86269
Fetched in submodule path 'test/yaml-test-suite', but it did not contain fa266d172ef7b2cdd35219b8e677fa5e0ae86269. Direct fetching of that commit failed.

Upstream issue: https://github.com/yaml/yaml-test-suite/issues/51

flyx commented 4 years ago

submodule was always a pain, should probably switch to git-subrepo so that upstream can't break it…

stefantalpalaru commented 4 years ago

As long as you target a certain commit and upstream decides to make that commit disappear, there's nothing you can do to prevent it.

flyx commented 4 years ago

git-subrepo will put an actual clone of upstream into this repository. If a commit vanishes upstream, it may be tricky to update the clone but that would only affect maintainers. Users will still be able to clone this repo with the currently cloned upstream state and thus not be affected by upstream, which is the goal.

keslerm commented 4 years ago

Is there a workaround for this atm?

flyx commented 4 years ago

I changed the commit reference to a release tag, they surely won't break those.