flyx / OpenGLAda

Thick Ada binding for OpenGL and GLFW
flyx.github.io/OpenGLAda/
MIT License
96 stars 13 forks source link

Framebuffer #138

Closed rogermc2 closed 4 years ago

rogermc2 commented 5 years ago

Additional routines needed to implement Transform Feedback facilities. Added Transform Buffer example to redbook examples Added Frustum_Matrix function to common Maths Also minor modifications to some examples.

rogermc2 commented 5 years ago

Please delay merging this PR as I am working on another red book example that requires more OpenGL procedures.

rogermc2 commented 5 years ago

I've now completed my current additions. I had attempted to implement a compute shader example but Apple does not support OpenGL beyond version 4.1. I have removed all the compute shader related code previously committed. Please inspect and merge at your convenience. Thanks, Roger

rogermc2 commented 4 years ago

I also removed (faulty) query related code from this branch. I must have done some initial query coding in the wrong branch! One of my typical blunders! Thanks for supporting my efforts. Slow responses are definitely not a problem.

rogermc2 commented 4 years ago

I think I've addressed your change request. See my 3 commits on 1 Dec 2019 and following comment also on 1 Dec 2019. I don't know why these commits and comment appear before the Changes request that they address?

flyx commented 4 years ago

My change request was to remove the Current_Transform_Buffers, not to change its type. This information is managed by OpenGL, hence we don't need it in the wrapper.

flyx commented 4 years ago

What is the package GL.Enums.Queries for? I don't see it being used anywhere.

flyx commented 4 years ago

I think we have reached a point where I need to think about separating the examples from the main repository. The process should be that we first discuss the changes to the API so that we're both happy with it and then the examples can come. Also, the repo seems to be overcrowded for someone who just want to use the library for their own needs. I will see if I can incorporate your changes with the changes I want in the process of splitting into two repos.

flyx commented 4 years ago

Merging this for now, I will apply changes afterwards.

flyx commented 4 years ago

Okay so I can't compile OpenGLAda anymore since SOIL cannot compile on macOS Catalina, as it depends on the Carbon API which has been removed in Catalina. I am evaluating options, this can take a while.

rogermc2 commented 4 years ago

Many many thanks for your attention. I think the package GL.Enums.Queries is used in the remaining branch PR #139. I don't expect to be making any more PRs. I am now using OpenGLAda extensively on another project which is the project that got me involved with OpenGLAda in the first place. I hope that OpenGLAda is being used by other Ada developers.

rogermc2 commented 4 years ago

I've updated my master but have found that many examples fail due to the buggy

 Utilities.Show_Shader_Program_Data (Rendering_Program);

I thought I'd commented this out of most examples but, apparently, not. Should I go ahead and comment it out in the examples of my query PR?

flyx commented 4 years ago

Please leave the other PR for now; it will be complex to merge as it is.

rogermc2 commented 4 years ago

OK. Thanks