search

flyx / OpenGLAda

Thick Ada binding for OpenGL and GLFW
flyx.github.io/OpenGLAda/
MIT License
96 stars 13 forks source link

Adding initial Ada OpenGL Bible example #21

Closed rogermc2 closed 7 years ago

rogermc2 commented 7 years ago

This is my first pull request. I'm not sure what's supposed to happen next. From the above comment I'm assuming that someone "with write access to this repository" will merge this pull request?

flyx commented 7 years ago

Yes, that would be me. I will look at your changes and give you some comments on what to improve. You can improve your PR by just pushing more changes to the my-examples branch in your fork.

rogermc2 commented 7 years ago

Thanks Flyx. This is a bit of a learning curve for me but hopefully I will learn from your comments. I've made the changes indicated above. I'm still not very competent with Gist yet; so more learning required and I'll leave off attempting to update my submission.

flyx commented 7 years ago

The important thing is that after you've made the changes, you need to commit them and then push them to your fork at GitHub. They will then automatically be applied here. So far, your changes have not yet arrived here.

rogermc2 commented 7 years ago

I believe I've committed and then pushed requested changes to my fork at GitHub. Is there anything else that I need to do at this stage. I'm using GitHub Desktop.

flyx commented 7 years ago

You did everything you needed to do. Please be patient, I may not have time for a review until after Christmas.

rogermc2 commented 7 years ago

OK, that's fine, I just wasn't sure of the process. Enjoy your Christmas.

rogermc2 commented 7 years ago

Absolutely no offense! I'm grateful for your advice. Regarding indentation and spacing; I agree absolutely, it has been annoying me also. My problem is with GPS which I must investigate how to get it to do things properly as, at the moment, it automatically formats things strangely; unlike other editors that I have used that do automatic indenting and colon alignment properly. It might take me a few days to attend to all your recommendations and will give me a break from fighting my framebuffer example. The formatting problem is that the GPS editor doesn't seem to display correctly. Finally fixed. The GPS editor was set to use a variable width font. Changing it to a fixed width font (Mac old faithfull Monaco) provided correct display of text alignment,

flyx commented 7 years ago

Note that I squashed your commits together in order to avoid unnecessary bloat in the commit history ;). This means that you should not further work on your my-examples branch since it now has a rather different history than the master branch.