flyxiv / ffxiv_simhelper_issues

0 stars 0 forks source link

Check DPS consistency #3

Closed flyxiv closed 1 month ago

flyxiv commented 1 month ago

Paladin's BIS DPS is 16k in the simulation, but as of now PLD dps go up to 18.9k.

Find out which calculation is off from reality.

flyxiv commented 1 month ago

contributions are also weak.

We need about 600 buff contribution for strong burst dps like SAM/VPR

Screenshot 2024-08-21 at 11 31 43 AM Screenshot 2024-08-21 at 11 32 27 AM
flyxiv commented 1 month ago

DRG damage is also 30% below current logs: DPS has to be 27k max

Screenshot 2024-08-21 at 11 37 17 AM Screenshot 2024-08-21 at 11 37 49 AM
flyxiv commented 1 month ago

Probably some simple calculation inconsistencies or the public FFXIV stat theory is wrong. Let's check after I come back from work.

flyxiv commented 1 month ago

Thankfully it seems like it's only a stat bug. Stats are different than etro on same set:

Screenshot 2024-08-21 at 7 48 28 PM
Screenshot 2024-08-21 at 7 48 56 PM
flyxiv commented 1 month ago

materias were off.

substats are ok.

main stat is missing. probably character base?

Screenshot 2024-08-21 at 7 52 26 PM
flyxiv commented 1 month ago

guess it's probably 5% from party contribution buffs

flyxiv commented 1 month ago

5% was correct, but the main stat multiplier is a bit off

Screenshot 2024-08-21 at 9 31 47 PM Screenshot 2024-08-21 at 9 25 59 PM
flyxiv commented 1 month ago

4882/2494% 5130/2626% 506/135% b * x - a

flyxiv commented 1 month ago

non tank is actually (237/440 = about 0.5386) main_stat - 440 tank is actually (190/440 = about 0.54) main_stat - 440 image

image

flyxiv commented 1 month ago

with the 5% bonus the power actually became weaker OoO

Screenshot 2024-08-21 at 9 51 19 PM
flyxiv commented 1 month ago

has to be 26.26

flyxiv commented 1 month ago

the engine had old multipliers, so the power actually went down. fixed now.

flyxiv commented 1 month ago

DPS is looking good now. Just need to fix buffs. They need to eat more.

Screenshot 2024-08-21 at 10 12 14 PM
flyxiv commented 1 month ago

auto attacks are lacking by 40%

Screenshot 2024-08-21 at 10 49 59 PM
flyxiv commented 1 month ago

need to add weapon multiplier to auto attack. Probably will solve the issues.

flyxiv commented 1 month ago

now all tuned correctly. all depends on job rotation.

Screenshot 2024-08-21 at 11 15 24 PM
flyxiv commented 1 month ago

Ninja can't auto attack while TCJ, Dancer can't auto attack while dancing etc, so we need to adjust auto attack interval with tuning constant

DNC: 137/175 = 0.78 SAM: 0.87 and so on

flyxiv commented 1 month ago

Calculate RDPS after calculating the final damage. even for crit/dh buffs

flyxiv commented 1 month ago

gcd speed buffs are applied reduce-multiplicatively rather than divisive ex) for a 10% speed buff, GCD != 2.50 / 1.1 = 2.27, but 2.50 * 0.9 = 2.25

flyxiv commented 1 month ago

there was a bug in crit/dh calculation when there is a guaranteed crit skill. fixed

flyxiv commented 1 month ago

DNC is fixed

Screenshot 2024-08-23 at 12 29 55 AM
flyxiv commented 1 month ago

too many procs for bard. one every gcd?

Screenshot 2024-08-23 at 12 36 07 AM
flyxiv commented 1 month ago

ticker bug fixed

flyxiv commented 1 month ago

for guaranteed crit/dh, it seems like not only crit dmg, but also the player's crit/dh percentage gets converted to damage increase.

so if the player's crit damage = 160%, crit % = 25%, the damage bonus isn't 160%, but 160% (100 + 25% (160% - 100%) = 160 * 115% = 190%

flyxiv commented 1 month ago

testing with same equipment, all melding dh and not melding dh.

after all meld: 1032

flyxiv commented 1 month ago

seems like it was already introduced in 6.2:

image

flyxiv commented 1 month ago

makes very much sense. apply this and we're done

flyxiv commented 1 month ago

still needs a bit more. let's test if there's a auto crit

crit: 790 image

flyxiv commented 1 month ago

crt doesn't give you extra damage. Just going to increase hammer traits. Can't figure out what's affecting the change.

flyxiv commented 1 month ago

dmg seems good now.

Screenshot 2024-08-23 at 10 20 10 PM
flyxiv commented 1 month ago

cache produced events and just use them.