Figure out best partner bug

[flyxiv]

• 120s simulation

• 30s simulation

• 

they should be the same, since there is no burst between 30s-120s, but they're different - clearly there's a bug

[flyxiv]

SAM has three columns..?

[flyxiv]

30 second fight:

INFO - saving 5299.570570897733 to 0 min, raid buff 601, skill id 1403
INFO - saving 2267.3475421400444 to 0 min, raid buff 601, skill id 1408
INFO - saving 7345.966907607653 to 0 min, raid buff 601, skill id 1418
INFO - saving 13547.126965861142 to 0 min, raid buff 601, skill id 1413
INFO - saving 3010.0153433064825 to 0 min, raid buff 601, skill id 1409
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1408
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1407
INFO - saving 3010.0153433064825 to 0 min, raid buff 601, skill id 1409
INFO - saving 18062.873034138855 to 0 min, raid buff 601, skill id 1410
INFO - saving 6585.01342539317 to 0 min, raid buff 601, skill id 1405
INFO - saving 6585.01342539317 to 0 min, raid buff 601, skill id 1417
INFO - saving 4947.293839982987 to 0 min, raid buff 601, skill id 1403
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1408
INFO - saving 7394.362224759141 to 0 min, raid buff 601, skill id 1418
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1408
INFO - saving 3010.0153433064825 to 0 min, raid buff 601, skill id 1409
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1408
INFO - saving 3400.8202180843778 to 0 min, raid buff 601, skill id 1409
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1407
INFO - saving 18062.873034138855 to 0 min, raid buff 601, skill id 1410
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1407

150 second fight:

INFO - saving 7440.218007793208 to 0 min, raid buff 601, skill id 1405
INFO - saving 4956.742303360821 to 0 min, raid buff 601, skill id 1403
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1408
INFO - saving 7740.3726010584505 to 0 min, raid buff 601, skill id 1418
INFO - saving 3010.0153433064825 to 0 min, raid buff 601, skill id 1409
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1408
INFO - saving 3010.0153433064825 to 0 min, raid buff 601, skill id 1409
INFO - saving 3010.0153433064825 to 0 min, raid buff 601, skill id 1409
INFO - saving 7525.761411584196 to 0 min, raid buff 601, skill id 1403
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1408
INFO - saving 2759.171461449942 to 0 min, raid buff 601, skill id 1400
INFO - saving 5243.74303629245 to 0 min, raid buff 601, skill id 1403
INFO - saving 7449.654200984762 to 0 min, raid buff 601, skill id 1418
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1407
INFO - saving 3010.0153433064825 to 0 min, raid buff 601, skill id 1409
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1407
INFO - saving 3010.0153433064825 to 0 min, raid buff 601, skill id 1409
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1407
INFO - saving 3010.0153433064825 to 0 min, raid buff 601, skill id 1409
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1407
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1408
INFO - saving 2759.171461449942 to 0 min, raid buff 601, skill id 1400
INFO - saving 2006.7510548523205 to 0 min, raid buff 601, skill id 1407

[flyxiv]

vpr 30s:

INFO - saving 1954.3574990410432 to 0 min, raid buff 601, skill id 2110
INFO - saving 7818.764863828154 to 0 min, raid buff 601, skill id 2116
INFO - saving 7818.764863828154 to 0 min, raid buff 601, skill id 2117
INFO - saving 7818.764863828154 to 0 min, raid buff 601, skill id 2118
INFO - saving 5749.052550824702 to 0 min, raid buff 601, skill id 2107
INFO - saving 1954.3574990410432 to 0 min, raid buff 601, skill id 2109
INFO - saving 1954.3574990410432 to 0 min, raid buff 601, skill id 2109
INFO - saving 7818.764863828154 to 0 min, raid buff 601, skill id 2117
INFO - saving 13223.19907940161 to 0 min, raid buff 601, skill id 2119

vpr 150s:

INFO - saving 2208.1250276247233 to 0 min, raid buff 601, skill id 2109
INFO - saving 8623.578826237053 to 0 min, raid buff 601, skill id 2114
INFO - saving 3219.3670886075947 to 0 min, raid buff 601, skill id 2120
INFO - saving 7818.764863828154 to 0 min, raid buff 601, skill id 2116
INFO - saving 3219.3670886075947 to 0 min, raid buff 601, skill id 2120
INFO - saving 3219.3670886075947 to 0 min, raid buff 601, skill id 2120
INFO - saving 5749.052550824702 to 0 min, raid buff 601, skill id 2107
INFO - saving 1954.3574990410432 to 0 min, raid buff 601, skill id 2110
INFO - saving 1954.3574990410432 to 0 min, raid buff 601, skill id 2109
INFO - saving 7818.764863828154 to 0 min, raid buff 601, skill id 2116
INFO - saving 8834.108871504402 to 0 min, raid buff 601, skill id 2117
INFO - saving 13223.19907940161 to 0 min, raid buff 601, skill id 2119
INFO - saving 5749.052550824702 to 0 min, raid buff 601, skill id 2107
INFO - saving 3219.3670886075947 to 0 min, raid buff 601, skill id 2123

[flyxiv]

doesn't happen for 30second, but my mental model was damage events are in chronological order, but the logs shows it breaking.

[flyxiv]

was a super hard bug to find..

i'm iterating through a hashmap, which means it's not guaranteed to be sorted - I'm not putting openers to the first index, i'm putting random burst minutes to the first index.

so we need to sort by burst minute after we're done inserting.

Now we can see VPR's low opener