search

fm-sys / snapdrop-android

Android client for local file sharing via https://snapdrop.net/ and https://pairdrop.net
https://play.google.com/store/apps/details?id=com.fmsys.snapdrop
GNU General Public License v3.0
838 stars 60 forks source link

Prevent localization by app if localization is built in #335

Closed schlagmichdoch closed 11 months ago

schlagmichdoch commented 11 months ago

Prevent localization by app if localization is built in on the current instance. Evaluate by checking if language-selector exists.

Fixes #334

fm-sys commented 11 months ago

Thanks, looks good!

fm-sys commented 11 months ago

As the language is chosen correctly by default, I'm thinking about hiding the language switch button to do not clutter the UI too much. While most websites offer language switching, android apps usually doesn't. Furthermore it would result in an inconsistent experience, as the language switch button will only translate the webview, not everything around it. What do you think?

schlagmichdoch commented 11 months ago

That‘s up to you. There should be any possibility to select the language though, either on the website or in the app settings. Also, what happens if a language is not selectable for snapdrop-android but for PairDrop (like Arabic) or the other way round?