search

fm-ticketing / dawn-shopify-theme

Clone of Shopify's Dawn theme, with Online Store 2.0 feature.
Other
1 stars 0 forks source link

Should it be possible for the Gift Aid field to be blank? #87

Open stuartleech opened 3 months ago

stuartleech commented 3 months ago

I've been pulling in all the line items to a spreadsheet for reporting purposes and I noticed that some web orders have no value in regards to gift aid which seems weird!

So this order has two tickets and a tip and where it should say TRUE or FALSE in regards to Gift Aid it's blank:

Screenshot 2024-06-04 at 14 44 54

I checked the order and you can see again there's no gift aid field here:

Screenshot 2024-06-04 at 14 43 13

Any ideas?

katjam commented 3 months ago

I can take a look. I think maybe there is some logic where we don't send anything if the gift aid part is not relevant.

stuartleech commented 3 months ago

Thanks!

That makes sense I think we're going to make it so there's only gift-aidable options but I think in this scenario those two tickets should have been giftaidable

It might also not have helped that the variants have been changed...

katjam commented 3 months ago

I better check how it is currently working and then you can tell me how we want it to work?

katjam commented 3 months ago

Yes. It looks like we only send a value for that line item if there is giftAidDeclaration. Do you want me to change it to send regardless? I think we thought it might confuse folks if the checkout said "Gift Aid declaration: false" when they'd not been given the option.

stuartleech commented 3 months ago

Ah of course I see what we did - we're about the make some amends to the ticket options which will mean they are all gift aid applicable so if we remove the non-gft aid ones do you need to do anything or will that just work because the excluded ones will no longer be there?

katjam commented 3 months ago

I think it will just work - but if not, should be quick fix.