fm4dd / nagios4dd

Collection of scripts and plugins for the open source monitoring system Nagios.
http://nagios.fm4dd.com
20 stars 13 forks source link

Update (and reduce) dependencies #8

Closed jefkel closed 6 years ago

jefkel commented 6 years ago

Tontonitch added option to ignore host check by adding Net::SSL module configurations, however this module adds a dependency on another external library.

The same feature can be added without adding another module requirement (using the newer perl module: IO::Socket::SSL) Also included is the (probable intent?) feature to ignore invalid SSL Certificates.

Documenting an additional dependency is also required now that perl-libwww-perl does not include https support: perl-LWP-Protocol-https-6.0Xxx.noarch

fm4dd commented 6 years ago

Hi nerrezz,

This may be indeed a better solution. Would it work to remove the full module path for SSL_verify_mode option since the module gets loaded, and the trailing commas, e.g. just specify it like this?

my $ua = LWP::UserAgent->new(ssl_opts => { verify_hostname => 0, SSL_verify_mode => SSL_VERIFY_NONE });

jefkel commented 6 years ago

I've updated as you noted (much cleaner) and tests are good on my system.