Delete confirmation has to be clicked twice

[fmaclen]

It might be being fired twice. Actually, pressing ENTER once also confirms the alert once. The test is technically also confirming the alert once so 🤷‍♂️

[binarynoise]

I liked the way HuggingChat solved the deletion. Not easy to do on accident but easy to do on purpose.

• hover over chat in list
• trash appears
• click on trash
• trash transforms into cancel
• confirmation is to the side
• move mouse over and confirm

also allows quick bulk deleting

[fmaclen]

@binarynoise I think I understand what you described but would you mind pasting a screenshot/s of HugginFace's delete flow so I can have as a reference? I'm not familiar with it.

[binarynoise]

and gone... as is my cursor in the screenshots, but I think you can still see where it hovers

[fmaclen]

I think this concept works, we should also probably replicate this behavior on the existing delete button.

If there's any chance you might be interested in submitting a PR, here's where the existing delete functionality exists:

• deleteSession()
• Delete <Button/>
• Test

[binarynoise]

No, sorry, I'm not familiar with your framework

[fmaclen]

Understood, I'll try to get it out soon

[binarynoise]

Thank you. It's not urgent though, the old button just works fine enough for now

[fmaclen]

:tada: This issue has been resolved in version 0.3.9 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

[binarynoise]

Looks and works great. Thanks for your work!

[fmaclen]

@binarynoise Thank you for the suggestion