fmaclen / svelte-currency-input

A masked form input that converts numbers to localized currency formats as you type
https://svelte-currency-input.fernando.is
MIT License
37 stars 5 forks source link

SvelteKit Import Error #68

Closed rac146 closed 11 months ago

rac146 commented 1 year ago

Ever since the 0.11 versions, I've been getting the following error when importing into my SvelteKit application:

image

I can safely ignore the error and application will still compile, but curious why this is popping up with 0.11 and not any of the previous versions..

fmaclen commented 11 months ago

I was able to replicate the error. I'll try to push a fix soon.

github-actions[bot] commented 11 months ago

:tada: This issue has been resolved in version 0.11.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

fmaclen commented 11 months ago

but curious why this is popping up with 0.11 and not any of the previous versions..

@rac146 a few weeks ago I did some maintenance on the package/release workflow and I messed up the configuration, and this is not covered by any tests so it flew under the radar.

Should be fixed in 0.11.2. Let me know if the issue still persists or something else is wrong. Thanks for reporting it!

rac146 commented 11 months ago

Thanks for fixing!

Something is still weird though.. now when trying to install 0.11.2, this is happening:

image

0.11.1 and other versions install correctly with svelte ^4.2.0

fmaclen commented 11 months ago

Oh, I see. I tested it on a project using Svelte 3.x and this didn't come up, but I do see this being an issue in projects with Svelte 4.x.

[Removed suggestion] Ignore my earlier suggestion, it wouldn't have worked.

I'll push a fix for this issue in https://github.com/fmaclen/svelte-currency-input/pull/72 In the meantime you can try:

npm i @canutin/svelte-currency-input@0.11.2 --legacy-peer-deps
fmaclen commented 11 months ago

For anyone having this problem in the future 0.11.3 should have fixed the issue, if it didn't please reply to this issue.