fmadio / public

fmadio issue tracking
MIT License
8 stars 3 forks source link

FCS errors not showing up in dashboard #198

Closed fmadio closed 7 years ago

fmadio commented 7 years ago

appears FCS errors not showing up in dashboard for some reason.

fmadio commented 7 years ago

all regressions passing, not sure whats hapening with the clients system. its clearly being written to the system event log file, but dashboard for some reason nothing gets added.

fmadio commented 7 years ago

likely a precision issue. due to how the FCS counter is accumulated beleive its dropping bits when the FCS error counts overflow 64bit float precision. test underway

fmadio commented 7 years ago

Specifically the problem is with FCS errors of 735,036,747,292 packets. For small # of FCS errors the code functions correctly.

sf0 Link encap:Ethernet HWaddr 00:0F:53:20:B2:F0 inet6 addr: fe80::20f:53ff:fe20:b2f0/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:9216 Metric:1 RX packets:775034282013 errors:735036747292 dropped:0 overruns:0 frame:735036747292 TX packets:23587574 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:57816662242649 (52.5 TiB) TX bytes:1509605240 (1.4 GiB) Interrupt:29

fmadio commented 7 years ago

the SHM stats file RxErrors (and drop counts) were 32bit floating point numbers. This causes LSB bit drops when the Rx Error counts are extremely high.

fixed.