search

fmal / gulp-inline-source

Inline flagged js & css sources.
MIT License
212 stars 31 forks source link

Work better with inline-source 5.2.0 #31

Closed LiberQuack closed 7 years ago

LiberQuack commented 7 years ago

Changed inline source dependency to ^5.0.0... This way we get all 5.x.x

inline-source just released 5.2.0 where we can inline every tag (not only pre-selected ones with inline attribute)

avanderhoorn commented 7 years ago

Sorry to ask, but any updates on this? Its blocking our usage and we would love to use this package.

LiberQuack commented 7 years ago

While there's no update... you can install my patch on your project temporally npm install --save martinsthiago/gulp-inline-source#patch-1

It's been some time I am using it with success

avanderhoorn commented 7 years ago

Thanks for the idea!

On Tue, Apr 4, 2017 at 1:33 PM Thiago Martins notifications@github.com wrote:

While there's no update... you can install my patch on your project temporally npm install --save martinsthiago/gulp-inline-source#patch-1

It's been some time I am using it with success

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fmal/gulp-inline-source/pull/31#issuecomment-291623490, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjvk_cPvIErXq_jLh0lrNz1A0BNOxDSks5rsqkxgaJpZM4MTkXs .

fmal commented 7 years ago

@MartinsThiago thanks for the PR. I just had to fix some failing tests and fixed inline-source to tilde range because that feels safer. @avanderhoorn @MartinsThiago apologies for the long wait. Released as 3.1.0.

avanderhoorn commented 7 years ago

Huge thanks!!!!

On Sun, Apr 9, 2017 at 1:53 PM Filip Malinowski notifications@github.com wrote:

@MartinsThiago https://github.com/MartinsThiago thanks for the PR. I just had to fix some failing tests and fixed inline-source to tilde range because that feels safer. @avanderhoorn https://github.com/avanderhoorn @MartinsThiago https://github.com/MartinsThiago Released as 3.1.0.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/fmal/gulp-inline-source/pull/31#issuecomment-292812175, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjvk45m4fyl08Ezp5J1tYx_68o7pqqeks5ruUUugaJpZM4MTkXs .

LiberQuack commented 7 years ago

Whoops, the tests... I totally forgot about them :sweat_smile: