fman-users / fman

Issue tracker for fman, a cross-platform file manager
https://fman.io
240 stars 3 forks source link

Add an option to render the UI with black text on a white (ish) background. #108

Open courtagenjim opened 7 years ago

courtagenjim commented 7 years ago

Benefits: 1) Minimizes the effects on the screen from glare (caused by sun; bright lights; etc.) 2) Is less distracting, jarring for users whose desktop/other applications default to dark on light. 3) Peer-reviewed studies confirm the dark text on a light background is optimal for legibility/readability.

Alternatively: let user explicitly specify which foreground, background color they want to use for the UI chrome and contents.

mherrmann commented 7 years ago

Thank you for filing an issue Jim. I think its implementation depends on #45. Once that's done, a "black on white" UI will be trivial to implement.

Are you set on "black on white" (it would be fair enough!), or would a general "light" theme also suit you? I know some users have already "hacked" fman to create light themes, however with slightly less contrast than pure black on white.

courtagenjim commented 7 years ago

The concerns are around usability; and NOT aesthetics. Personally I don't care if the background is not pure white, as long as the text contrast is high. However, if you're going to go with a 'general "light" theme", then I'd suggest that the background color (if not pure white) should be fairly neutral (e.g., very light gray; alternating light gray and white rows; very light blue 'tint' (i.e., CSS: 'aliceblue'); or a very light yellow tint (i.e., CSS: 'oldlace'). But I recommend that the text be kept as pure black, or very close (i.e., CSS: #333).

mherrmann commented 7 years ago

I understand. I'll take it into account. Actually, the light theme "hacked" by the user has black on white, sorry for the wrong information. He based it on VS Code's Light theme. I hope he won't mind me sharing his screenshot here:

image

The white "highlight" in GoTo on Steroids has too little contrast (that's why being able to style this is mentioned in #45).

courtagenjim commented 7 years ago

That "hacked" light theme looks about like what I'm recommending. However, I can't tell for sure from the the screen shot. Can you point me to a URL where I can see that/download it? TIA.

mherrmann commented 7 years ago

That screenshot is all I have, sorry :/

alin23 commented 7 years ago

@courtagenjim This is the best I could do: https://gist.github.com/alin23/7f28cde8df2fad414c2b445e448e4c6d You need to replace styles.qss in the fman's installation directory with the one from the link above. On macOS the file is located here: /Applications/fman.app/Contents/Resources/styles.qss

mherrmann commented 7 years ago

It's cool that @alin23 found this out. Just a word of caution: styles.qss is an implementation detail and not officially supported. Changes you make to it may break at any moment. Further, the file gets overwritten with each update.

I'm happy for you to make any changes! Just wrote the above so you know the caveats.

woli commented 7 years ago

Here's the style that was used in that screenshot. I didn't update it to the latest version of fman yet so it's not matching it anymore, but it can still be useful.

fman-light-theme.zip

mherrmann commented 7 years ago

Thank you @woli!

thomas-haslwanter commented 5 years ago

So what is the recommended way now to change to a light UI? I find the dark impossible to read.

thomas-haslwanter commented 5 years ago

And If I want to use woli's theme: where (on a windows machine) would I put it?

mherrmann commented 5 years ago

@thomas-haslwanter in fman's installation directory. That's %LOCALAPPDATA%\fman\Versions\x.y.z. You will overwrite the styles.qss file that is there. As mentioned above, this is (unfortunately) not yet officially supported. And the file gets overwritten with each fman update.

kirylx commented 4 years ago

also waiting for the light theme implementation

C0Nd3Mnd commented 3 years ago

This is (sadly) the one thing that holds me back from buying a license, an official light theme 😅

yusiwen commented 3 years ago

This is (sadly) the one thing that holds me back from buying a license, an official light theme 😅

Bro, same here. I hate dark themes and feel desperately disappoint to find there is no official light theme.

ChillarAnand commented 1 year ago

Any plans on creating a white theme?