search

fman-users / fman

Issue tracker for fman, a cross-platform file manager
https://fman.io
240 stars 3 forks source link

Open with editor doesn't work #264

Closed greenelephant closed 6 years ago

greenelephant commented 6 years ago

Nothing happens when I use "Open with editor" option from menu. When I create a file editor opens fine and I can save one.

"Open with editor" doesn't work no matter if I use from command palette or shortcuts.

System: Arch Linux Version 0.7.6-1

mherrmann commented 6 years ago

That's strange. By "when I create a file" you mean Shift+F4?

greenelephant commented 6 years ago

Yes, I can use Shift+F4 and it works just fine. File is created and then editor opens.

mherrmann commented 6 years ago

Thanks for clarifying. And it also doesn't work when you then F4 on the file that was just created?

greenelephant commented 6 years ago

Exactly.

mherrmann commented 6 years ago

Strange. Okay! Thanks. I'll take a look.

greenelephant commented 6 years ago

Did you have a chance to look at this issue? How do you open a file? (I'm a python programmer, maybe I could help). I would like to start using fman but it's useless without open in editor option.

raguay commented 6 years ago

Do you have my version of OpenWithEditor that makes use of the BitBar editor selector? That plugin takes some extra configurations. If not set, it will look like nothing happens. I never got around to making it more friendly, but I will. As far as I know, I'm about the only one using it. It would be nice to get some stats on a plugins usages (hint, hint...). 😄

mherrmann commented 6 years ago

:smile: subtle @raguay, veeery subtle ;)

@greenelephant I'll take another look today, sorry.

mherrmann commented 6 years ago

But what @raguay said is actually an interesting question @greenelephant: Did you install any plugins?

greenelephant commented 6 years ago

Guys, I removed user folder and started configuration from scratch. Everything is working fine. Now I have only ArrowNavigation plugin. Before this I had OpenWithEditor but haven't installed it now. Thank you for help :)

mherrmann commented 6 years ago

Great to hear it's resolved! So it appears this was caused by a plugin overwriting an existing command. I didn't think people would overwrite commands, but some plugins did (why wouldn't they). That's why it's now officially discouraged by the API.

Closing this issue :)

raguay commented 6 years ago

Sorry, but the latest version doesn't overwrite the command, but the keyboard assignment is redone using the new bb open with editor command.

mherrmann commented 6 years ago

Yes, absolutely. What I meant was that an old plugin overwrote the command, sorry. I was trying to highlight this an example of why it is better not to overwrite existing commands for (perhaps) other readers.