search

fmang / opustags

Ogg Opus tags editor
BSD 3-Clause "New" or "Revised" License
75 stars 10 forks source link

Stream numbers #14

Closed rr- closed 8 years ago

rr- commented 8 years ago

Man page reads:

The identifer of a stream is determined from its position in the file. The first Opus stream found will have id 1, the second 2, and so on. Non-Opus streams are not numbered.

You can select more than one stream with this option by separated id's with commas. For example: --stream 1,3. Ranges are not supported.

...but right now, the handlers receive streamno rather than sequential stream identifier. As such, running ./opustags test.ogg --export results in following:

[Stream -336916309]
LANGUAGE=und
HANDLER_NAME=SoundHandler
ENCODER=Lavc57.24.102 libopus
MAJOR_BRAND=isom
MINOR_VERSION=512
COMPATIBLE_BRANDS=isomiso2avc1mp41

which is not what the manpage promised.

I don't think maintaining sequential order should be handled by TagHandlers, cause it'll need to introduce duplicated code everywhere. I'd like to let actions.cc deal with this.

fmang commented 8 years ago

Commit 1ff2553 implements that. Remains to decide whether to include unknown (non-Opus) stream when assigning sequence numbers. See the commit's message.

rr- commented 8 years ago

Imho it should include unknown streams in the numbering sequences. Consider how the user might use different tools that are aware of such streams - they might fall under the impression that opustags doesn't see such streams, or even strips them away on tag writing.

fmang commented 8 years ago

You're totally right. That's settled then.