Say you do --stream 2 --add TITLE=X. We've got two problematic cases:
Stream 2 doesn't exist.
Stream 2 isn't an Opus stream.
In both cases, the user should at least be warned.
Technically, in these scenarii, the ITagsHandler::list isn't called, which makes that kind of detection a bit less obvious: it should be done in ITagsHandler::end_of_file. For non-Opus streams, we detect the problem right from ITagsHandler::start_of_file which passes the type of the stream as a parameter.
Say you do
--stream 2 --add TITLE=X. We've got two problematic cases:In both cases, the user should at least be warned.
Technically, in these scenarii, the
ITagsHandler::listisn't called, which makes that kind of detection a bit less obvious: it should be done inITagsHandler::end_of_file. For non-Opus streams, we detect the problem right fromITagsHandler::start_of_filewhich passes the type of the stream as a parameter.