search

fmang / opustags

Ogg Opus tags editor
BSD 3-Clause "New" or "Revised" License
82 stars 11 forks source link

1.1.1 #20

Closed zvezdochiot closed 6 years ago

zvezdochiot commented 6 years ago

Define project NAME, VERSION

fmang commented 6 years ago

I'm not sure I get the point of this pull request.

Is there any reason you'd need the version bumped?

zvezdochiot commented 6 years ago

Is there any reason you'd need the version bumped?

Subversion for designation only. As an example. Main: use define.

PS: I am a party Debian. Combining git and dpkg becomes a problem. Introducing subversions is a compromise.

fmang commented 6 years ago

Usually, the version number and project name are defined in a config.h header, created by the build system like autoconf or cmake, which also affects the man page. Moving the version number from the version string to a dedicated version macro in the same C file doesn't improve anything, and manually creating a config.h would be just as meaningless.

You're also mixing up the project name and the executable name. If you wanna be flexible on the usage string, you should use argv[0]. But honestly, it's not even worth the effort.

If you'd like to contribute to opustags, please send me an email and we'll talk about it.

fmang commented 6 years ago

I've bumped the version and tagged, but don't plan on creating constants for the project name and version. See 7174a1f