fmang / opustags

Ogg Opus tags editor
BSD 3-Clause "New" or "Revised" License
75 stars 10 forks source link

Fails to build on macos high sierra #44

Closed SuperSandro2000 closed 3 years ago

SuperSandro2000 commented 3 years ago

I am currently reviewing the NixOS package update to 1.5.0 (https://github.com/NixOS/nixpkgs/pull/103484) which breaks building on MacOS with the following error:

these derivations will be built:                                                                                                                                                              /nix/store/n3ajm7hfx6r33k8n4wkbl8ap86sv2y6h-opustags-1.5.1.drv                                                                                                                            building '/nix/store/n3ajm7hfx6r33k8n4wkbl8ap86sv2y6h-opustags-1.5.1.drv'...                                                                                                                unpacking sources                                                                                                                                                                           unpacking source archive /nix/store/gbbiyd793s21iimmgdgzjr3s8ahfsfpl-source                                                                                                                 source root is source                                                                                                                                                                       patching sources                                                                                                                                                                            configuring                                                                                                                                                                                 fixing cmake files...                                                                                                                                                                       cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1/share/doc/opustags -DCMAKE_INSTALL_INFODIR=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1/include -DCMAKE_INSTALL_SBINDIR=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/l5707pca91sq99fd5fq4x84302zssyjj-cctools-binutils-darwin-949.0.1/bin/strip -DCMAKE_RANLIB=/nix/store/l5707pca91sq99fd5fq4x84302zssyjj-cctools-binutils-darwin-949.0.1/bin/ranlib -DCMAKE_AR=/nix/store/l5707pca91sq99fd5fq4x84302zssyjj-cctools-binutils-darwin-949.0.1/bin/ar -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_INSTALL_PREFIX=/nix/store/83vmz7l3ksy68fgqzb5pz8dqwbr0dw8h-opustags-1.5.1                                                                                                         -- The CXX compiler identification is Clang 7.1.0                                                                                                                                           -- Detecting CXX compiler ABI info                                                                                                                                                          -- Detecting CXX compiler ABI info - done                                                                                                                                                   -- Check for working CXX compiler: /nix/store/b2qvdc4738nl7d8bn6d5gb6p9s34c78v-clang-wrapper-7.1.0/bin/clang++ - skipped                                                                    -- Detecting CXX compile features                                                                                                                                                           -- Detecting CXX compile features - done                                                                                                                                                    -- Found PkgConfig: pkg-config (found version "0.29.2")                                                                                                                                     -- Checking for module 'ogg'                                                                                                                                                                --   Found ogg, version 1.3.4                                                                                                                                                               -- Performing Test Iconv_IS_BUILT_IN
-- Performing Test Iconv_IS_BUILT_IN - Failed
-- Found Iconv: /nix/store/x3r5250ll1k97j6n7sn9k035wz9n7jnz-libiconv-osx-10.12.6/lib/libiconv.dylib
-- Looking for C++ include endian.h
-- Looking for C++ include endian.h - not found
-- Looking for C++ include sys/endian.h
-- Looking for C++ include sys/endian.h - not found
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING
    CMAKE_C_COMPILER
    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_POLICY_DEFAULT_CMP0025

-- Build files have been written to: /tmp/nix-build-opustags-1.5.1.drv-0/source/build
cmake: enabled parallel building
building
build flags: -j4 -l4 SHELL=/nix/store/k89nm2jva0qmvd970f84wq2iq1iwm9bs-bash-4.4-p23/bin/bash
Scanning dependencies of target ot
[ 14%] Building CXX object CMakeFiles/ot.dir/src/cli.cc.o
[ 28%] Building CXX object CMakeFiles/ot.dir/src/ogg.cc.o
[ 42%] Building CXX object CMakeFiles/ot.dir/src/opus.cc.o
[ 57%] Building CXX object CMakeFiles/ot.dir/src/system.cc.o
/tmp/nix-build-opustags-1.5.1.drv-0/source/src/system.cc:182:13: error: no member named 'st_mtim' in 'stat'
        mtime = st.st_mtim; // more precise than st_mtime
                ~~ ^
1 error generated.
make[2]: *** [CMakeFiles/ot.dir/build.make:121: CMakeFiles/ot.dir/src/system.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:149: CMakeFiles/ot.dir/all] Error 2
make: *** [Makefile:149: all] Error 2
builder for '/nix/store/n3ajm7hfx6r33k8n4wkbl8ap86sv2y6h-opustags-1.5.1.drv' failed with exit code 2
error: build of '/nix/store/n3ajm7hfx6r33k8n4wkbl8ap86sv2y6h-opustags-1.5.1.drv' failed

I think this is an issue in your source code. If you need someone for testing feel free to ping me.