search

fmang / opustags

Ogg Opus tags editor
BSD 3-Clause "New" or "Revised" License
82 stars 11 forks source link

Broken funtionality under musl #46

Closed 0xJes closed 3 years ago

0xJes commented 3 years ago

Some code in this program uses gnu libc specific //TRANSLIT suffix which is not supported in musl libc, I discovered this by trying to package opustags for Void Linux.

musl is an alternative libc used in Linux distributions like Alpine, Adélie and Void.

See iconv section in this wiki page

I don't know how hard it would be to support musl libc, do you think it can be done?

fmang commented 3 years ago

Thanks for the report. I’ll look into that.

I never liked //TRANSLIT in the first place so maybe I’ll drop it and introduce --raw for users with encoding issues instead.

Have you confirmed opustags works file if you remove //TRANSLIT?

0xJes commented 3 years ago

I changed line 174 on src/cli.cc to: 

static ot::encoding_converter from_utf8("UTF-8", "");

Now seems to work fine, the program prints tags from files and I can edit tags with --edit