search

fmang / opustags

Ogg Opus tags editor
BSD 3-Clause "New" or "Revised" License
82 stars 11 forks source link

Add flexibility regarding encodings #47

Closed fmang closed 3 years ago

fmang commented 3 years ago

Use //IGNORE instead of less-widely supported //TRANSLIT, meaning invalid characters will be skipped. @0xJes could you please confirm musl accepts this?

Introduce --raw for disable encoding conversions when they get in the way.

Close #46.

0xJes commented 3 years ago

Still can't view tags or edit them with --edit, even using the --raw option, trying to do so still fails with this error:

terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
Exception: ./opustags killed by signal aborted
fmang commented 3 years ago

Hmm, that suggests //IGNORE is not compatible either with musl.

Now that I introduced --raw, I made encoding errors fatal. That makes a better safety net that was we used to have.

Could you try the new version I just pushed?

0xJes commented 3 years ago

It works now!

fmang commented 3 years ago

Great, thanks for the feedback!

I plan to release that as 1.6.0 in about a week.