Closed rr- closed 5 years ago
I agree on that it's a bad idea to try to automatically correct user's command without knowing their true intent.
Perhaps an additional flag --fix-ordering-for-me-please
(or its opposite, whichever will be default) would be the best of both worlds, provided this flag is known to the user beforehand.
But still, forcibly fixing user's mistakes without their knowledge won't help anyone in the long run.
I see two options:
--add
then --delete
).Noting also that something like --import --add X=Y --import
is strange if we want to preserve the original order. This case is in favor of option 1.
Right now this call
adds
ARTIST
and then deletes theARTIST
, which results in removal of all priorARTIST
entries and not addingARTIST=omg
entry. The proposition is to introduce "smart ordering" (I just called it that) to CLI arguments so that it's always like this:-e
,--import
,--delete-all
--delete
)--set
)--add
)With this, it'd remove all the
ARTIST
entries and add oneARTIST=omg
entry, essentially replacing all artists withomg
.I'm not a fan of this approach since, beside sub-ideal code it needs to introduce, it feels kind of counter-intuitive to me; after all I just told the program to add a tag, and then delete a tag. I'd expect it to do just that - the fact it's a silly thing to do is just my fault for telling it to do something silly.
We could use external opinion on this.