search

fmang / opustags

Ogg Opus tags editor
BSD 3-Clause "New" or "Revised" License
75 stars 10 forks source link

1.6.1: add opuspic2tag #58

Closed zvezdochiot closed 2 years ago

zvezdochiot commented 2 years ago
fmang commented 2 years ago

It’s true opustags currently lacks proper support for cover pictures, but your tool does not seem to integrate to opustags at all. Why not maintain it in a different repository?

zvezdochiot commented 2 years ago

@fmang say:

but your tool does not seem to integrate to opustags at all.

What??? :astonished: :open_mouth: :frowning: :no_mouth:

fmang commented 2 years ago

Nowhere in the documentation you wrote do you mention how to add a cover art to an Opus file, or how to extract it. As far as I can tell, it would require quite a few tricks. I also noticed that you opened a very similar PR at https://github.com/hcmiya/opuscomment/pull/19. It’s pretty clear that you didn’t design your tool for opustags in the first place.

Besides, the approach you suggested a few years ago in #21, i.e. adding a new flag to opustags, would be much more convenient. Still, I expect you to make smaller pull requests, one feature at a time, and follow the architecture of the code if you want me to merge them.

zvezdochiot commented 2 years ago

@fmang say:

Nowhere in the documentation you wrote do you mention how to add a cover art to an Opus file

Like everything else.

@fmang say:

It’s pretty clear that you didn’t design your tool for opustags in the first place.

No, opuspic2tag was originally developed for opustags. And only recently ported to opuscomment.

@fmang say:

I expect you to make smaller pull requests

No. Your position is lie. I don't intend to deal with you in the future.

Summary: :astonished: :open_mouth: :frowning: :no_mouth: