search

fmang / opustags

Ogg Opus tags editor
BSD 3-Clause "New" or "Revised" License
82 stars 11 forks source link

Let TagHandler know when all streams have been processed #6

Closed rr- closed 8 years ago

rr- commented 8 years ago

There are a few ways to accomplish this:

  1. Create an event ITagsHandler::start_of_file(const int stream_count)
  2. Create an event ITagsHandler::end_of_file()
  3. Both?

In any case, I'd like to avoid introducing any kind of state to ITagsHandler and let StreamTagsHandler deal with state as a part of its implementation.

fmang commented 8 years ago

Option 2 has been ready for a while, it's called end_of_stream and could benefit from a better name.

I think this is enough to implement all we'd ever need.

rr- commented 8 years ago

In that case, my proposition would be end_of_file or end_of_streams. Could you change the name?

fmang commented 8 years ago

Done. I added ITagsHandler::start_of_stream too so that the lister is aware of the unknown streams.