search

fmang / opustags

Ogg Opus tags editor
BSD 3-Clause "New" or "Revised" License
81 stars 11 forks source link

Win/MingW build doesn't support getline() and mkstemps() #61

Closed gitoss closed 1 year ago

gitoss commented 1 year ago

The latest 1.8 version of opustags adds an important fix for the infamous "Reading header packets spanning multiple pages are not yet supported." drawback.

However only the older, buggy 1.6 binary can be compiled and found 'round the net because, from the hydrogenaudio forum: "The current version of opustags relies on at least two POSIX functions - getline() and mkstemps() - that haven't been implemented in Mingw-w64 yet" https://hydrogenaud.io/index.php/topic,121444.msg1026198.html#msg1026198

Could you please re-add Win/MinGW support, or are these two POSIX funtions the exact ones that are required to fix the bug and/or add features like cover picture support? The alternative could be a Cygwin version with its POSIX wrappers, but this would have to be tested for any regressions.

fmang commented 1 year ago

To be honest I’ve never had Windows in mind when writing opustags. I didn’t know people made builds for Windows, but I’m glad they’re making opustags accessible to more people! I’m open to making opustags more Windows-friendly if someone shows me build logs, or makes pull requests.

opustags has been using getline since 1.2.0, and mkstemps since 1.5.0, so the explanation you quote does not match up. Regarding the support of multi-page packets, I don’t see how that could possibly break Windows compatibility. It’s most likely something else.

fmang commented 1 year ago

Closing for inactivity. Please open an issue with a build log if you’d like to help improve Windows compatibility.