search

fmang / oshu

Fast osu! port for Linux (and more)
GNU General Public License v3.0
120 stars 8 forks source link

Lint #53

Closed fmang closed 6 years ago

fmang commented 6 years ago

I haven't used a linter for oshu! so far 😇

Clang-Tidy or CppCheck can probably help detect a few potential errors. I should at least try them out of curiosity.

VPeruS commented 6 years ago

Additionally what about integratation of linter in pr process with travis?

lanodan commented 6 years ago

Maybe there could also be things like clang/LLVM scan-build.

fmang commented 6 years ago

clang-tidy detected 2cded58. The other linters didn't find anything. Static analysis is hard eh. Beside, the typer does most of the job.

CMake integrates clang-tidy easily:

set_target_properties(
  my-target-name PROPERTIES
  CXX_CLANG_TIDY clang-tidy
)

The compilation gets very slow though.

That's it for today.