search

fmarotta / kaobook

A LaTeX class for books, reports or theses based on https://github.com/kenohori/thesis and https://github.com/Tufte-LaTeX/tufte-latex.
https://github.com/fmarotta/kaobook
LaTeX Project Public License v1.3c
859 stars 185 forks source link

kaohandt.cls: Fix #174 by commenting out l.100 as suggested #184

Closed bcw closed 3 years ago

bcw commented 3 years ago

This change fixes an error reported by another user (ratmice) in https://github.com/fmarotta/kaobook/issues/174 where compilation fails with kaohandt.cls (they call it kaohandt.sty by mistake). It looks like the corresponding statement in kaobook.cls (l.256) has already been commented out, so I think this change (as they suggest) is OK.

But to be sure, I tried compiling the minimal_report example with a few settings of the secnumdepth class option (including commented out per default), both with and without this change. Compilation seems to fail without this change, and succeed (and look reasonable) with it.

bcw commented 3 years ago

Looks like one of your tests failed... by failing to produce a log file (edit: possibly due to a missing .fls file, but IDK what that even is). Bummer, but I'm not sure whether the problem is with my change or the testing setup. Since I don't know, I'll not make any further changes until you get a chance to look at it. If there's anything I can (and need) to fix, please let me know by leaving a comment here. Thank you for all your work.

fmarotta commented 3 years ago

Hi, many thanks! I think the automatic test didn't fail because of your changes (I experienced similar failures in the past). I'll look into the problem after merging your PR.