Fix issues related to listings

fmarotta / kaobook

A LaTeX class for books, reports or theses based on https://github.com/kenohori/thesis and https://github.com/Tufte-LaTeX/tufte-latex.

https://github.com/fmarotta/kaobook

LaTeX Project Public License v1.3c

859 stars 185 forks source link

Fix issues related to listings #225

Closed pi8027 closed 1 month ago

pi8027 commented 2 years ago

This PR introduces a new class option listing=(listings|minted) and fixes #236. Now, kao.sty requires either listings.sty or minted.sty depending on the users' choice. The marginlisting environment supports only the chosen package.

listings:

Fix the spacing issue in marginlisting. This is done by supplying format=margin to \captionsetup.
There is no wide lstlisting environment yet.

minted:

Add the wide listing* environment.
Count \c@listing within chapter.

Other changes:

The separator in captions in marginlisting is redone using labelsep=colon, but the numbers=enddot class option is not properly supported.
The \floatsetup declarations are refactored.

pi8027 commented 2 years ago

I found that this PR does not work with the listings package. I will try to fix it.

fmarotta commented 2 years ago

Hi, thanks! What's the state of this PR, after closing #235?

pi8027 commented 2 years ago

Sorry. I still need some more time to properly redo this PR.

pi8027 commented 2 years ago

Almost there! I still have to do something with TOC (List of Listings), which is not very clear to me at the moment. The first commit, which properly fixes the sparing issue in marginlisting, might be useful on its own.

pi8027 commented 2 years ago

Done.

ehhc commented 1 month ago

@fmarotta any news on this? Will it be merge soon? btw: thanks for your great work :)

fmarotta commented 1 month ago

Great work, thanks @pi8027! Yes, I will merge this right now.

fmarotta commented 2 weeks ago

I've added some docs and credits to the documentation: https://github.com/fmarotta/kaobook/commit/e4ee5fb3cb3d7e665eca807978040054291e074c