fmartinou / tydom2mqtt

Deltadore Tydom to MQTT Bridge
https://fmartinou.github.io/tydom2mqtt/
MIT License
86 stars 49 forks source link

Feature : Add custom presets for unmanaged device #124

Closed darkradish closed 10 months ago

darkradish commented 10 months ago

Hello, I had new deltadore 4890 connected to my Tydom box and these sondes doesn't support presets, so i had a variable named PRESETS_MANUAL which managed presets inside this mqtt addon. It works fine for me in production, but the code can be better. you can test with setting PRESETS_MANUAL={'ECO':'16', 'COMFORT': '19'} for exemple if Presets_manual is not set, no impact.

fmartinou commented 10 months ago

Hi,

Thank you for your contribution! 👍

That seems to be a "very edge case" but... why not ;)

Can you please update your PR with the following items:

  1. Rename the configuration property from PRESETS_MANUAL to something easier to understand (like THERMOSTAT_CUSTOM_PRESETS for example?)
  2. Complete the documentation to describe this new configuration property here
  3. Add a dedicated section to the documentation configuration page to explain why/how to use it

Thank you very much 😃

darkradish commented 10 months ago

Hi,

Thank you for your contribution! 👍

That seems to be a "very edge case" but... why not ;)

Can you please update your PR with the following items:

  1. Rename the configuration property from PRESETS_MANUAL to something easier to understand (like THERMOSTAT_CUSTOM_PRESETS for example?)
  2. Complete the documentation to describe this new configuration property here
  3. Add a dedicated section to the documentation configuration page to explain why/how to use it

Thank you very much 😃

Is it better ? :)

fmartinou commented 10 months ago

Yes, thank you! 👍

fmartinou commented 10 months ago

For information, I had to fix that because it was failing when the feature wasn't used: https://github.com/fmartinou/tydom2mqtt/commit/60115dcca87aaee89d6e34d4eb4e037895a0a931

fmartinou commented 10 months ago

Released as 3.4.1