Closed darkradish closed 10 months ago
Hi,
Thank you for your contribution! 👍
That seems to be a "very edge case" but... why not ;)
Can you please update your PR with the following items:
PRESETS_MANUAL
to something easier to understand (like THERMOSTAT_CUSTOM_PRESETS
for example?)Thank you very much 😃
Hi,
Thank you for your contribution! 👍
That seems to be a "very edge case" but... why not ;)
Can you please update your PR with the following items:
- Rename the configuration property from
PRESETS_MANUAL
to something easier to understand (likeTHERMOSTAT_CUSTOM_PRESETS
for example?)- Complete the documentation to describe this new configuration property here
- Add a dedicated section to the documentation configuration page to explain why/how to use it
Thank you very much 😃
Is it better ? :)
Yes, thank you! 👍
For information, I had to fix that because it was failing when the feature wasn't used: https://github.com/fmartinou/tydom2mqtt/commit/60115dcca87aaee89d6e34d4eb4e037895a0a931
Released as 3.4.1
Hello, I had new deltadore 4890 connected to my Tydom box and these sondes doesn't support presets, so i had a variable named PRESETS_MANUAL which managed presets inside this mqtt addon. It works fine for me in production, but the code can be better. you can test with setting PRESETS_MANUAL={'ECO':'16', 'COMFORT': '19'} for exemple if Presets_manual is not set, no impact.