add HVAC switch mode (...)

[JBSC]

add HVAC switch mode. Some fix on getting in-memory data. Management of default temperature values for heating and cooling modes.

[aberlioz]

@fmartinou do you think we could merge this ?

[fmartinou]

I have full confidence in you 😃 .

[fmartinou]

Take your chance with the new 3.5.0 version which has just been released.

[fmartinou]

Hi @JBSC If you're still around... This PR seems to break the MQTT config override.

https://github.com/fmartinou/tydom2mqtt/issues/192

https://github.com/fmartinou/hassio-addons/issues/19

[JBSC]

Belle boulette, fixée dans #193, désolé

Il reste également le fond, ajouter proprement le support des nouveaux paramètres dans fmartinou/hassio-addons (j'oublie ce dépôt aujourd'hui)

Bref il faut que je me monte une recette pour hassio-addons :upside_down_face:

[fmartinou]

Thanks for the fix 👍 .

I'm going to add the missing config entries in the hassio-addons.

[fmartinou]

@JBSC

Here is the change I've pushed on the hassio-addons repository: https://github.com/fmartinou/hassio-addons/commit/b0dcb0cf265fbd27e25553195dff73c9ee80d07c

[aberlioz]

Hey @fmartinou @JBSC 👋🏻 Thanks for the release and the fix, I've just tried it out and I have no errors, just the logic in cooling mode which is inverted. I missed it at the review, it's just a matter of changing the comparison, I've made the fix PR: https://github.com/fmartinou/tydom2mqtt/pull/195

@fmartinou While we're on that note, how do you feel if we were to add tests to this project to ensure stability and non-regression when making changes ?

[fmartinou]

While we're on that note, how do you feel if we were to add tests to this project to ensure stability and non-regression when making changes ?

It will be a big step forward 👍

For the record, I'm not the original founder of this project and I got it back "as it". Currently, you're right; many devices are supported and it's hard to ensure backward compatibility when bringing code changes.

In addition to unit tests, there are also these 2 issues which are not addressed very well:

• testing with real devices (personally I only have a single tybox device so I'm very limited)
• making easy to support new devices over time

++

[aberlioz]

While we're on that note, how do you feel if we were to add tests to this project to ensure stability and non-regression when making changes ?

It will be a big step forward 👍

For the record, I'm not the original founder of this project and I got it back "as it". Currently, you're right; many devices are supported and it's hard to ensure backward compatibility when bringing code changes.

In addition to unit tests, there are also these 2 issues which are not addressed very well:

• testing with real devices (personally I only have a single tybox device so I'm very limited)
• making easy to support new devices over time

++

Yes for sure, I know the history of that project, and it's already a great thing that you're keeping it alive!

Testing with real devices will be hard, I only have boiler at my house, so we would need some kind of list of beta testers for a version, covering several devices...

Anyway I'll try to look into adding unit tests in the coming weeks 🤞🏻

[BlacKTM1190]

Hello

Testing with real devices will be hard, I only have boiler at my house, so we would need some kind of list of beta testers for a version, covering several devices...

I don't have many much devices but some covers, lights, a Tywatt and garage door. Like @fmartinou , time is running out in this moment but I would be glad to give feedback. Ready for testing :saluting_face:

[Otiel]

I own a TYDOM 1 box with heating devices, I can offer some of my time to help testing as well. 🤓