fmartinou / tydom2mqtt

Deltadore Tydom to MQTT Bridge
https://fmartinou.github.io/tydom2mqtt/
MIT License
90 stars 53 forks source link

get tydom credentials from Delta Dore #99

Closed CyrilP closed 1 year ago

fmartinou commented 1 year ago

Hi @CyrilP ,

That's awesome; thank you very much! It will drastically reduce the burden of onboarding new usersπŸ‘

=> I'm going to review it this week-end

fmartinou commented 1 year ago

Hi,

I tested your PR with success πŸ‘

You can find my comments above that should improve code quality.

In addition, the documentation should also be enriched about the new available props.

The DELTADORE_LOGIN and DELTADORE_PASSWORD have to be described here in the documentation

And I think they deserve a clear explanation;

Thank you! πŸ‘

CyrilP commented 1 year ago

I did the requested changes

fmartinou commented 1 year ago

Thank you very much! LGTM πŸ‘

fmartinou commented 1 year ago

Just released as 3.1.0. (the hass.io addon has been updated to allow passing the deltadore credentials)