Closed CyrilP closed 1 year ago
Hi,
I tested your PR with success π
You can find my comments above that should improve code quality.
In addition, the documentation should also be enriched about the new available props.
The DELTADORE_LOGIN
and DELTADORE_PASSWORD
have to be described here in the documentation
And I think they deserve a clear explanation;
TYDOM_PASSWORD
resolutionTYDOM_PASSWORD
is providedThank you! π
I did the requested changes
Thank you very much! LGTM π
Just released as 3.1.0
.
(the hass.io addon has been updated to allow passing the deltadore credentials)
Hi @CyrilP ,
That's awesome; thank you very much! It will drastically reduce the burden of onboarding new usersπ
=> I'm going to review it this week-end