search

fmartinou / whats-up-docker

What's up Docker ( aka WUD ) gets you notified when a new version of your Docker Container is available.
https://fmartinou.github.io/whats-up-docker
MIT License
1.02k stars 33 forks source link

Broken favicon for web ui #156

Closed kinglike1337 closed 2 years ago

kinglike1337 commented 2 years ago

When creating a bookmark in firefox I noticed an error: The favicon is not displayed.

After digging around I saw that in the html multiple favicons are linked in the following order:

<link rel="icon" type="image/svg+xml" href="/img/icons/favicon.svg">
<link rel="icon" type="image/png" sizes="32x32" href="/img/icons/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="/img/icons/favicon-16x16.png">

Firefox tries to get the first entry favicon.svg. This files does not exist and an html error page is returned with status 200.

Firefox seems to stop here and shows a broken/unknown favicon. With Chromium the next icon is loaded and is visible.

fmartinou commented 2 years ago

I added the missing svg file. The fix will be available in the upcoming 5.20.2 version.