search

fmartinou / whats-up-docker

What's up Docker ( aka WUD ) gets you notified when a new version of your Docker Container is available.
https://fmartinou.github.io/whats-up-docker
MIT License
1.02k stars 33 forks source link

Trigger MQTT - Add Client ID variable #244

Closed Pampersfr closed 1 year ago

Pampersfr commented 1 year ago

hi,

it's possible to add Client ID when we use MQTT Trigger ? i use docker compose so, in environment variable ? today it's random client id that is used : 1679329796: New client connected from xxxxxxxx as **mqttjs_598a6124** (p2, c1, k60, u'MQTTClient').

thanks a lot

fmartinou commented 1 year ago

Hi,

The random part is still interesting to avoid any overlapping when running multiple clients, I think.

What's your real issue with that random value?

Is it just because it's not obvious to correlate this random mqttjs_xxx id to wud? If so, wouldn't it be better to keep some kind of randomness but prefixed by something more understandable than mqttjs?

For example wud_$uid?

Pampersfr commented 1 year ago

Hi Is it just because it's not obvious to correlate this random mqttjs_xxx id to wud? yes exactly

For example wud_$uid? yes it's perfect this

Thanks a lot

fmartinou commented 1 year ago

By the way, it's already released (6.1.0).

Pampersfr commented 1 year ago

and already installed ;-) thanks a lot