search

fmartinou / whats-up-docker

What's up Docker ( aka WUD ) gets you notified when a new version of your Docker Container is available.
https://fmartinou.github.io/whats-up-docker
MIT License
1.02k stars 33 forks source link

Allow anonymous access to GCR #262

Closed bossm8 closed 1 year ago

bossm8 commented 1 year ago

Hi folks, first of all thank you for this cool project!

I am using cadvisor which is hosted publicly on google's container registry. But there is no option like WUD_REGISTRY_HUB which enables the registry anonymously. I have now used a workaround like this in my docker-compose which works fine and I am able to check for new versions of the cadvisor image:

environment:
      WUD_REGISTRY_GCR_CLIENTEMAIL: "testmail@test.com"
      WUD_REGISTRY_GCR_PRIVATEKEY: "test"

Perhaps there could also be an option WUD_REGISTRY_GCR or this workaround could be added to the documentation?

fmartinou commented 1 year ago

Hi,

Thank you for the feedback! 👍

=> I'll change the code to allow configuring the GCR registry without credentials.

fmartinou commented 1 year ago

By the way, now with the fix;

If no GCR registry integration is configured, then an integration allowing anonymous access is created by default (the same as for hub, quay...).

So no need to set WUD_REGISTRY_GCR=""; it should work out-of-the-box.

bossm8 commented 1 year ago

Great! Thank you for the really quick implementation!