search

fmaussion / salem

Add geolocalised subsetting, masking, and plotting operations to xarray
http://salem.readthedocs.io
Other
186 stars 44 forks source link

Fix shapely deprecation warnings and remove descartes dependency #210

Closed fmaussion closed 3 years ago

fmaussion commented 3 years ago

@TimoRoth any idea what's going on with coveralls again? Do we have a way to get the tests green even if coveralls has a hickup maybe?

fmaussion commented 3 years ago

Ah OK that's the issue: https://github.com/TheKevJames/coveralls-python/issues/333

fmaussion commented 3 years ago

closes https://github.com/fmaussion/salem/issues/211

jorisvandenbossche commented 2 years ago

FYI, you could slim down the "vendored" file with descartes' code quite a bit, if you wanted, see https://github.com/geopandas/geopandas/issues/1039#issuecomment-748625852 (which is what we did in geopandas: https://github.com/geopandas/geopandas/blob/831108dcb369517e311cd0ee3821db1f2fb7122d/geopandas/plotting.py#L100-L123)

fmaussion commented 2 years ago

Thanks a lot for the heads up @jorisvandenbossche ! Much appreciated