fix(metadata): explicitly set version - Githubissues

fmaussion / salem

Add geolocalised subsetting, masking, and plotting operations to xarray

http://salem.readthedocs.io

Other

186 stars 44 forks source link

fix(metadata): explicitly set version #249

Closed benatouba closed 3 months ago

benatouba commented 4 months ago

salem.version now correctly reflects the version of the package.

[ ] closes #xxxx
[ ] tests added / passed
[x] passes git diff upstream/master | flake8 --diff
[x] whatsnew entry

salem.utils reads package metadata, but version number was not explicitly set. This resulted in version numbering v0.1+githash for regardless of real release number.

fmaussion commented 3 months ago

Thanks! Sorry i missed this. But normally this should be done automatically based on the git tag or commit. Awaiting input from @TimoRoth on how to do this nicely - there must be a good way available somewhere.

fmaussion commented 3 months ago

See https://github.com/fmaussion/salem/issues/250

Thanks for the report!