search

fmaussion / salem

Add geolocalised subsetting, masking, and plotting operations to xarray
http://salem.readthedocs.io
Other
186 stars 44 forks source link

Workflow updates and artifact uploads #253

Closed TimoRoth closed 3 months ago

fmaussion commented 3 months ago

Is it expected that all tests are red?

TimoRoth commented 3 months ago

Given they all fail with the same two google maps tests failing with a 403, and neither PRs nor my Repo having access to the maps key, I'd say so.

TimoRoth commented 3 months ago

Wait, the non-mpl ones fail with a different error about not knowing the mpl argument. Which makes sense. Need to think of a way to solve that, hm.

fmaussion commented 3 months ago

Given they all fail with the same two google maps tests failing with a 403, and neither PRs nor my Repo having access to the maps key, I'd say so.

Still, something is wrong with this because the tests should be skipped if no key is provided

fmaussion commented 3 months ago

That was the purpose of requires_static_key - will have to look into this when the other tests are green.

TimoRoth commented 3 months ago

Seems like you just forgot the two gmaps-using tests in test_datasets.py.