search

fmbenhassine / jql

Java code analysis and linting with SQL
https://github.com/benas/jql/wiki
MIT License
157 stars 11 forks source link

Upgrade the JavaParser dependency #9

Closed matozoid closed 6 years ago

matozoid commented 6 years ago

There are a lot of known bugs in JavaParser 2.4.0, making this a rather urgent upgrade.

fmbenhassine commented 6 years ago

Hi Danny,

Happy to see you here! Thank you for this PR and thank you for the wonderful java parser library!

I didn't have time to update this repo yet, it is still in PoC stage and the code was written in a quick and dirty manner. I was just trying to see if the idea works and if the relational model is good enough (see my blog post about it).

Anyway, I will merge your changes asap.

Best regards Mahmoud

matozoid commented 6 years ago

Cool! Just think of it like this: at least no potential user will be disappointed when it fails on parse errors on valid source code :-)

(Actually, it would be best to completely disable AST validations then... hmmmm...)

fmbenhassine commented 6 years ago

I have some time to work on jql this week.

Thank you for your PR!