search

fmbiete / Z-Push-contrib

Z-Push fork with changes that I will try to contrib
GNU Affero General Public License v3.0
135 stars 62 forks source link

Fix "Undefined index" warnings using CalDAV backend #154

Closed gmta closed 9 years ago

gmta commented 9 years ago

I had set CALDAV_SUPPORTS_SYNC incorrectly (using SabreDAV 1.8.6 instead of the supported 1.9+) and CalDAVClient err'ed on me when it tried to access its sync tokens, which it of course did not have.

This adds a clear warning message informing the user of a possible fix and prevents the "Undefined index" warnings from occurring by checking if a token is available.

Quite possibly fixes issue #139.

The UTF-8 fix makes the commit diff human readable by github. :-)

fmbiete commented 9 years ago

Great finding! That really make sense and the warning will help notice the problem to the sysadmins.