search

fmckeogh / usb-pd-rs

USB-PD and associated hardware driver libraries in Rust
MIT License
19 stars 4 forks source link

Added feature gate to work with latest embassy. #6

Closed bentwire closed 6 months ago

bentwire commented 10 months ago

Probably needs some cleanup..

bentwire commented 10 months ago

Hmm not sure why the build is failing. I didn't set those options...

fmckeogh commented 10 months ago

@bentwire If embassy seems to be replacing RTIC in the ecosystem I'm more than happy to just make this an embassy-first library and if anyone needs the original time implementation they can add a compat feature, does that work for you?

bentwire commented 10 months ago

I'm fine with that. Its supposed to go live (posted to crates.io) in the next week as soon as some features get in to stable compiler.

So far I like it. Only been messing with it for a week though.

fmckeogh commented 10 months ago

@bentwire You're the only library user right now and the project I'm doing is easy to move to a new framework. Ideally I'd like to avoid using features for as long as possible.

bentwire commented 10 months ago

@fmckeogh

Yes I agree the features make it ugly. The one thing I like about embassy is async. I think this lib could benefit from embassy for that reason alone.

I'm fine with doing a full async port to embassy if you are.

bentwire commented 10 months ago

@fmckeogh I could start by just moving to embassy blocking as the code works as is with it, and that is how I am using it currently.

bentwire commented 10 months ago

I think I need to add a rust-toolchain.toml to fox that build failure. At least until embassy is on stable rust.

Hopefully it won't be too much longer. They are waiting for a couple features related to async getting in stable.

fmckeogh commented 6 months ago

Superseded by #10