mtr processes keep remaining as zombies

fmdlc / ISP-Checker

Kubernetes and Docker Compose files to run ISP checks on a Raspberry Pi. 📊

https://www.youtube.com/watch?v=BnQDnCNG1Bs

Apache License 2.0

130 stars 32 forks source link

mtr processes keep remaining as zombies #36

Open sotn3m opened 3 years ago

sotn3m commented 3 years ago

Hi, I was experiencing significant amount of zombie processes. These were all mtr processes under telegraf.

My proposal: https://github.com/sotn3m/ISP-Checker/commit/d292f77294d4f3d71e03955cc155b0706b86b836

This has solved problems in my environment.

I have read somewhere that using init: true is a good practice, so presumably this can be left as is even when telegraf/mtr start working correctly.

fmdlc commented 3 years ago

Hi! Thank you! I will take a look and keep you posted. Probably you're right about this!.

thorerik commented 3 years ago

Tested your fix on my pi, and it resolved the issue, should PR the changes 👍

villasenor commented 2 years ago

To solve this in Kubernetes, we'll need to manually change the entrypoint for the container build to use tini or something though. The existing PR does take care of the docker-compose case, but we could fix this for everyone in one change by fixing the image.