Replace dependency `colored` with `bunt` - Githubissues

fmease / lushui

The reference compiler of the Lushui programming language

Apache License 2.0

7 stars 0 forks source link

Replace dependency `colored` with `bunt` #96

Closed fmease closed 1 year ago

fmease commented 3 years ago

Motivation

colored only offers ColoredStrings i.e. owned head-allocated strings which is very wasteful especially since we use a lot of colored string literals
- I am not in the mood to fork the library and add a ColoredStr<'_>
I actually don't like the API anymore, the extension methods, as it leads to quite verbose and boilerplate-y code (nested format!s etc.)

Blockers

Issue #21: I'd like to support "runtime"/dynamic color specifications since I don't want to speckle my code with hard-coded colors but I'd like to define color constants with semantic naming (see the diagnostics code)

Open Questions

How does it deal with the NO_COLOR environment variable?

fmease commented 1 year ago

Superseded by https://github.com/fmease/lushui/pull/176.