search

fmeringdal / nettu-meet

Open source video conferencing system for tutors.
GNU Affero General Public License v3.0
2.28k stars 286 forks source link

Fix: Slider inside the ColorPicker did not budge if present color is set to 'Black' #39

Open Hyungeol94 opened 12 months ago

Hyungeol94 commented 12 months ago

When the present color was set to "Black," there was a bug in the ColorPicker component that prevented the slider from moving.

If the onChange is called, an alpha value, which is a hsv color type, needs to be injected into the ColorPicker component. This necessity is reflected in the modified version.

I really hope this works.

fmeringdal commented 12 months ago

Hey @Hyungeol94 , thanks for the MR. What exactly is the error? Does the slider never work or only when you explicitly set the color to black does it stop working?

Hyungeol94 commented 12 months ago

Hello @fmeringdal. It happened only for the latter case.