search

fmeringdal / nettu-meet

Open source video conferencing system for tutors.
GNU Affero General Public License v3.0
2.28k stars 286 forks source link

Edge browser support #9

Closed fmeringdal closed 3 years ago

mfkp commented 3 years ago

https://github.com/fmeringdal/nettu-meet/blob/main/frontend/src/pages/EntryPage.tsx#L126

Maybe it does work on Windows (I see it's listed under a "Windows" category), but I am using Edge browser on Linux:

https://www.microsoftedgeinsider.com/en-us/download/?platform=linux

Version 92.0.884.2 (Official build) dev (64-bit)

mfkp commented 3 years ago

Also, I just noticed a typo here on this line:

https://github.com/fmeringdal/nettu-meet/blob/main/frontend/src/pages/EntryPage.tsx#L147

"bowser" should be "browser" :-)

Bowser

edit: nevermind on the bowser part, I see it's using a "bowser" package lol (but I'll leave it here because I like the picture)

fmeringdal commented 3 years ago

Thanks for the details! Edge + Linux is an interesting combo :grin: I think that edge should work regardless of OS as it uses chromium. So the only thing to do is to add an entry to the supportedBrowsers variable so that it matches with the linux + edge combo.

Do you want to try to fix that? Otherwise I will fix it when I have some time to spare :)

mfkp commented 3 years ago

Let me know when it's deployed/live and I'll test it out for you.

fmeringdal commented 3 years ago

Great! It should be live now

mfkp commented 3 years ago

Hm, I'm not seeing the updates yet (I made sure the cache is cleared and whatnot):

screenshot

fmeringdal commented 3 years ago

Oh looks like something is broken in the pipeline. I pushed the update manually now, and verified that that the updated version is live now.

mfkp commented 3 years ago

Perfect, just confirmed it's working great in Edge Browser on Linux :-)

fmeringdal commented 3 years ago

Awesome! 🎉 Thanks for helping out on this!