search

fmeringdal / nettu-scheduler

A self-hosted calendar and scheduler server.
MIT License
535 stars 27 forks source link

Namespace environment variables and collection names #4

Closed claytongulick closed 3 years ago

claytongulick commented 3 years ago

Thanks for the cool project! Scheduling isn't a simple problem, I'm looking forward to digging into this project more.

I noticed in the server setup that the environment variables aren't namespaced and could potentially conflict with other app settings. It's probably a good idea to prepend NETTU_ to the environment variables.

Also, it's probably a good idea to add a configurable prefix to the mongo collection names. In my case, my primary application is also using Mongo as a store, I'd want to have all the of nettu bookings etc... share a db with my project so that it's easy to use in aggregation pipelines, etc... and directly available to the app for consumption.

I'll take a look into adding some mongoose models for NodeJS that can be used for the collections you're creating and contribute them to the project.

Thanks again!

fmeringdal commented 3 years ago

Thanks for giving this project a shot!

I completely agree that namespacing of environment variables and mongo collection names would be a good idea. I can write a descriptive PR for you if you have time and would like to implement this? Should be quite simple. Otherwise I can take on the task :)