Fixed problem with uniqueness of short codes #223

fmfi-svt / anketa

Študentská anketa FMFI a iných fakúlt UK

https://anketa.uniba.sk/

Other

0 stars 1 forks source link

Fixed problem with uniqueness of short codes #223 #230

Closed vidriduch closed 7 years ago

vidriduch commented 7 years ago

Shortening of a subjects code now leaves the numbers after second "/" because old short codes were no longer unique as mentioned in issue #223
With this change we loose ability to look at history of a subjects

Signed-off-by: Ondrej Jariabka o.jariabka@gmail.com

This change is

Sameth commented 7 years ago

Sorry, ze tak neskoro. Anyway, asi by som radsej videl mierne bezpecnejsiu formu regexu, ktora matchuje aj so zaciatkom (podobne, ako v povodnej verzii), v idealnom pripade dokonca este aj s koncom stringu.

Motivacia:

Kto si ma pamatat, ci to matchuje najviac a najskor, ako moze.
Co ked sa nieco v PHP zmeni.

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

vidriduch commented 7 years ago

@Sameth Ok, zmenil som to tak aby ten regex pripominal viac ten povodny. Dufam ze to staci.

Sameth commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable