Fix ticheho preskakovania zlyhanych zaznamov

[Sameth]

Pocas importu ucitelov-predmetov

Touto zmenou sa bude do konzoly vypisovat aspon nieco o tom, ake zaznamy sa nepodarilo spracovat. Niektore detaily sa po konzultacii mozu pomenit.

---

This change is 

[mrshu]

Za mna bez vacsich problemov, iba nejake male nitpicky. Kludne sa na ne vykasli a mergni si to, ak uznas za vhodne.

---

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

---

src/AnketaBundle/Command/ImportUcitelPredmetCommand.php, line 86 at r1 (raw file):

        $rows = 0;
        $rows_success = 0;

Zda sa, ze v ankete (alebo specialne v src/AnketaBundle/Command/ sa skor pouziva camelCase ako podtrhovniky. Nieje to nejaky velky problem, ale asi by bolo dobre skusit byt konzistentny.

---

src/AnketaBundle/Command/ImportUcitelPredmetCommand.php, line 107 at r1 (raw file):

                if (strlen($aisNazov) == 0) {
                    $output->writeln($aisDlhyKod . ': Chýba meno predmetu');

Nezda sa mi, ze by sa v Ankete nejako moc pouzivala diakritika, ale chapem, ze toto bude asi vystup, ktory sa bude niekam posielat, takze to dava zmysel.

---

Comments from Reviewable

[Sameth]

Tak som pofixoval, co som nasiel. Heh, v uprave query bol pomerne zasadny bug, snad uz nic dalsie neni.

Btw, v arene som testoval, ci hentaky update (v insert query) funguje a tvari sa, ze hej.

---

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

---

src/AnketaBundle/Command/ImportUcitelPredmetCommand.php, line 86 at r1 (raw file):

Previously, mrshu (Marek Šuppa) wrote…

Zda sa, ze v ankete (alebo specialne v `src/AnketaBundle/Command/` sa skor pouziva camelCase ako podtrhovniky. Nieje to nejaky velky problem, ale asi by bolo dobre skusit byt konzistentny.

Done.

---

src/AnketaBundle/Command/ImportUcitelPredmetCommand.php, line 107 at r1 (raw file):

Previously, mrshu (Marek Šuppa) wrote…

Nezda sa mi, ze by sa v Ankete nejako moc pouzivala diakritika, ale chapem, ze toto bude asi vystup, ktory sa bude niekam posielat, takze to dava zmysel.

Hej, toto sa planuje posielat, navyse mena, ktore tam chcem pre lepsie trackovatelne hlasky tiez vypisovat, su s diakritikou a hentak by to vyzeralo hlupo. Nieze by to v novej uprave vyzeralo uzasne (hlavne s poslednymi dvomi riadkami v anglictine), ale... well, spravit to kulturne by vyzadovalo cas a hrabanie sa v moznostiach Symfony.

---

Comments from Reviewable

[mrshu]

Diki moc,

---

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

src/AnketaBundle/Command/ImportUcitelPredmetCommand.php, line 90 at r2 (raw file):

                    FROM User a, Subject b
                    WHERE a.login = :login and b.slug = :slug
                    ON DUPLICATE KEY UPDATE trainer=1");

Jezkove voci, toto bol hodne velky miss z mojej strany -- sorry. Presne pre toto by tieto testy chcelo integracne testovat, co sa teda viac menej robi v arene, tazke velka vdaka, ze si to skusal.

---

Comments from Reviewable

[mrshu]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

src/AnketaBundle/Command/ImportUcitelPredmetCommand.php, line 90 at r2 (raw file):

Previously, mrshu (Marek Šuppa) wrote…

Jezkove voci, toto bol hodne velky miss z mojej strany -- sorry. Presne pre toto by tieto testy chcelo integracne testovat, co sa teda viac menej robi v arene, tazke velka vdaka, ze si to skusal.

---

Comments from Reviewable