fix reports error when user has no department

[Adman]

• If a user had i.e. department reports role assigned and no department assigned at the same time, the app crashed with error. This fix just skips such users.
• fixes #285

Signed-off-by: Adrian Matejov ado.matejov@gmail.com

---

This change is 

[mrshu]

@Adman This does indeed do what it says it does (thanks for putting to together) but I am not really convinced if we want to fix the issue on this level.

As in, shouldn't every user with a "department reports" role have a department role assigned?

[tvinar]

Yes, and the system should work in a way that it encourages admins to fix the issue. BUT, it is bad if the whole section of the website is unavailable to users simply because of missing data next to one teacher...

---

Tomas Vinar, Associate Professor Department of Applied Informatics Faculty of Mathematics, Physics, and Informatics Comenius University, Bratislava E-mail: @.*** Office: M163 Work Phone: +421-2-60295207

On Sat, Apr 3, 2021 at 5:05 PM Marek Šuppa @.***> wrote:

@Adman https://github.com/Adman This does indeed do what it says it does (thanks for putting to together) but I am not really convinced if we want to fix the issue on this level.

As in, shouldn't every user with a "department reports" role have a department role assigned?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/fmfi-svt/anketa/pull/286#issuecomment-812877619, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAV5KYYEERNULDTKR7L5CNTTG4VE7ANCNFSM42JPWEMA .

[mrshu]

All right, let's go with this then (although I would very much prefer us to receive an email or something when it happens :slightly_smiling_face:)

[Adman]

I'll probably add listing of people who have ROLE_DEPARTMENT_REPORTS assigned but their department is NULL.

[Adman]

Added the listing of people, who have got ROLE_DEPARTMENT_REPORTS but no department assigned.