fmgasparino / google-gin

Automatically exported from code.google.com/p/google-gin
Apache License 2.0
0 stars 0 forks source link

AsyncProvider should generate meaningful split point names #109

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When using an AsyncProvider, all the split points locations are named:

   @somepackage.YourGinjectorImpl$5.get

since the underlying code uses GWT.runAsync() without the extra Class 
parameter.  Passing the 
Class object for the object being retrieved would make SoYC reports far easier 
to read.

Original issue reported on code.google.com by awi...@google.com on 3 Jun 2010 at 5:11

GoogleCodeExporter commented 9 years ago
We could do that with separately declared inner classes, will look into it 
if/when we
find time.

Original comment by aragos on 3 Jun 2010 at 5:21

GoogleCodeExporter commented 9 years ago
I think it's easier than that - just use the raw type of the binding.  See the 
attached patch in issue 110 (sorry about two issues in one patch).  I patched 
it in, 
and the SoYC report is now meaningful.

On the downside, this does register the same class name for multiple split 
points if 
you have annotated AsyncProviders or AsyncProviders for generic types - I don't 
know 
if GWT allows that or not.  If it does, I think this is still a significant 
improvement over the state of affairs.

Original comment by awi...@google.com on 3 Jun 2010 at 8:54

GoogleCodeExporter commented 9 years ago
I'll use the patch for 110 to upload a codereview, adapted to the current state 
of the project.

Original comment by aragos on 21 Jan 2011 at 9:36

GoogleCodeExporter commented 9 years ago
Patch submitted for review at http://codereview.appspot.com/4038043.

Original comment by aragos on 21 Jan 2011 at 9:53

GoogleCodeExporter commented 9 years ago
Patch committed in r160.

Original comment by aragos on 21 Jan 2011 at 11:35