fmgasparino / google-gin

Automatically exported from code.google.com/p/google-gin
Apache License 2.0
0 stars 0 forks source link

Structured documentation of relaxed visibility #135

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Per http://code.google.com/p/google-gin/issues/detail?id=86, often classes are 
made public for sake of being accessible by a Ginjector in another package.

It's useful to include an annotation to describe this versus using free form 
comments of the sort:
 // class is public because ....

Annotation file is attached.

Original issue reported on code.google.com by ffa...@gmail.com on 29 Jan 2011 at 4:15

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for submitting this patch! While I like the idea, I'd prefer an actual 
solution to the original problem even better: Gin could be adapted so as to be 
able to inject default access/protected types in packages not visible to the 
injector. One way to do this is to generate a class in each affected package 
from which we can then create and inject the required objects without having to 
see them in the actual injector implementation in the ginjector package. 

Original comment by aragos on 12 Feb 2011 at 10:58

GoogleCodeExporter commented 9 years ago
Makes sense....I'm of the same mindset.  

No promises but I'll poke around and see what I can do also with bridging 
classes.

Original comment by ffa...@gmail.com on 13 Feb 2011 at 12:19